-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Revert "Add assert to MethodSetter to trigger traceback" #48183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Add assert to MethodSetter to trigger traceback" #48183
Conversation
|
please test |
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48183/44958 |
|
A new Pull Request was created by @Dr15Jones for CMSSW_15_1_RNTUPLE_X. It involves the following packages:
@jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ca1e37/46380/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_15_1_RNTUPLE_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Reverts #48078
Since adding the ROOT fix, we are no longer triggering this assert. As the assert was only meant to help catch the race condition, we can now remove it.